Skip to content
Snippets Groups Projects
Commit af87fa1a authored by Wilson Jallet's avatar Wilson Jallet :clapper:
Browse files

quaternion: fix constructors taking const Eigen::Ref

* should take Eigen::Ref of const (to dispatch to proper EigenAllocator)
parent eaebb7ea
No related branches found
No related tags found
No related merge requests found
...@@ -294,8 +294,8 @@ class QuaternionVisitor ...@@ -294,8 +294,8 @@ class QuaternionVisitor
return q; return q;
} }
static Quaternion* FromTwoVectors(const Eigen::Ref<Vector3> u, static Quaternion* FromTwoVectors(const Eigen::Ref<const Vector3> u,
const Eigen::Ref<Vector3> v) { const Eigen::Ref<const Vector3> v) {
Quaternion* q(new Quaternion); Quaternion* q(new Quaternion);
q->setFromTwoVectors(u, v); q->setFromTwoVectors(u, v);
return q; return q;
...@@ -308,12 +308,12 @@ class QuaternionVisitor ...@@ -308,12 +308,12 @@ class QuaternionVisitor
static Quaternion* DefaultConstructor() { return new Quaternion; } static Quaternion* DefaultConstructor() { return new Quaternion; }
static Quaternion* FromOneVector(const Eigen::Ref<Vector4> v) { static Quaternion* FromOneVector(const Eigen::Ref<const Vector4> v) {
Quaternion* q(new Quaternion(v[3], v[0], v[1], v[2])); Quaternion* q(new Quaternion(v[3], v[0], v[1], v[2]));
return q; return q;
} }
static Quaternion* FromRotationMatrix(const Eigen::Ref<Matrix3> R) { static Quaternion* FromRotationMatrix(const Eigen::Ref<const Matrix3> R) {
Quaternion* q(new Quaternion(R)); Quaternion* q(new Quaternion(R));
return q; return q;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment