Compare revisions

Florent Lamiraux · Guilhem Saurel · Guilhem Saurel · Guilhem Saurel · Guilhem Saurel · Guilhem Saurel
--- a/.git-blame-ignore-revs
+++ b/.git-blame-ignore-revs
+# pre-commit run -a (Guilhem Saurel, 2022-07-27)
+db4d991c9d727b8454695ce8d88948b948c6b36f
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
+exclude: tests/test_python-syntax_error.py
+ci:
+    autoupdate_branch: 'devel'
+repos:
+-   repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v14.0.6
+    hooks:
+    -   id: clang-format
+        args: [--style=Google]
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.3.0
+    hooks:
+    -   id: check-added-large-files
+    -   id: check-ast
+    -   id: check-executables-have-shebangs
+    -   id: check-json
+    -   id: check-merge-conflict
+    -   id: check-symlinks
+    -   id: check-toml
+    -   id: check-yaml
+    -   id: debug-statements
+    -   id: destroyed-symlinks
+    -   id: detect-private-key
+    -   id: end-of-file-fixer
+    -   id: fix-byte-order-marker
+    -   id: mixed-line-ending
+    -   id: trailing-whitespace
+-   repo: https://github.com/psf/black
+    rev: 22.8.0
+    hooks:
+    -   id: black
+-   repo: https://github.com/PyCQA/flake8
+    rev: 5.0.4
+    hooks:
+    -   id: flake8
+-   repo: https://github.com/cheshirekow/cmake-format-precommit
+    rev: v0.6.13
+    hooks:
+    - id: cmake-format
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
-# Copyright 2010-2020, Florent Lamiraux, Thomas Moulard, Olivier Stasse, Guilhem Saurel, JRL, CNRS/AIST, LAAS-CNRS
+# Copyright 2010-2020, Florent Lamiraux, Thomas Moulard, Olivier Stasse, Guilhem
+# Saurel, JRL, CNRS/AIST, LAAS-CNRS

-CMAKE_MINIMUM_REQUIRED(VERSION 3.1)
+cmake_minimum_required(VERSION 3.1)

 # Project properties
-SET(PROJECT_ORG stack-of-tasks)
-SET(PROJECT_NAME dynamic-graph-python)
-SET(PROJECT_DESCRIPTION "Dynamic graph library Python bindings")
-SET(PROJECT_URL "https://github.com/${PROJECT_ORG}/${PROJECT_NAME}")
+set(PROJECT_ORG stack-of-tasks)
+set(PROJECT_NAME dynamic-graph-python)
+set(PROJECT_DESCRIPTION "Dynamic graph library Python bindings")
+set(PROJECT_URL "https://github.com/${PROJECT_ORG}/${PROJECT_NAME}")

 # Project options
-OPTION(SUFFIX_SO_VERSION "Suffix library name with its version" ON)
+option(SUFFIX_SO_VERSION "Suffix library name with its version" ON)

 # Project configuration
-SET(PROJECT_USE_CMAKE_EXPORT TRUE)
-SET(CUSTOM_HEADER_DIR "dynamic-graph/python")
-SET(CXX_DISABLE_WERROR TRUE)
-SET(DOXYGEN_USE_MATHJAX YES)
+set(PROJECT_USE_CMAKE_EXPORT TRUE)
+set(CUSTOM_HEADER_DIR "dynamic-graph/python")
+set(CXX_DISABLE_WERROR TRUE)
+set(DOXYGEN_USE_MATHJAX YES)

 # JRL-cmakemodule setup
-INCLUDE(cmake/base.cmake)
-INCLUDE(cmake/boost.cmake)
-INCLUDE(cmake/python.cmake)
+include(cmake/base.cmake)
+include(cmake/boost.cmake)

 # Project definition
-COMPUTE_PROJECT_ARGS(PROJECT_ARGS LANGUAGES CXX)
-PROJECT(${PROJECT_NAME} ${PROJECT_ARGS})
-CHECK_MINIMAL_CXX_STANDARD(14 ENFORCE)
+compute_project_args(PROJECT_ARGS LANGUAGES CXX)
+project(${PROJECT_NAME} ${PROJECT_ARGS})
+check_minimal_cxx_standard(14 ENFORCE)

 # Project dependencies
-FINDPYTHON()
-
-ADD_PROJECT_DEPENDENCY(dynamic-graph 4.4.0 REQUIRED)
-ADD_PROJECT_DEPENDENCY(eigenpy REQUIRED)
-SEARCH_FOR_BOOST_PYTHON(REQUIRED)
-IF(BUILD_TESTING)
-  FIND_PACKAGE(Boost REQUIRED COMPONENTS unit_test_framework)
-ENDIF(BUILD_TESTING)
-
-IF(Boost_VERSION GREATER 107299 OR Boost_VERSION_MACRO GREATER 107299)
+set(PYTHON_COMPONENTS Interpreter Development NumPy)
+add_project_dependency(dynamic-graph 4.4.0 REQUIRED)
+add_project_dependency(eigenpy 2.7.10 REQUIRED)
+set(PYTHON_EXPORT_DEPENDENCY_MACROS
+    "list(APPEND PYTHON_COMPONENTS ${PYTHON_COMPONENTS})\n${PYTHON_EXPORT_DEPENDENCY_MACROS}"
+)
+if(BUILD_TESTING)
+  find_package(Boost REQUIRED COMPONENTS unit_test_framework)
+endif(BUILD_TESTING)
+
+if(Boost_VERSION GREATER 107299 OR Boost_VERSION_MACRO GREATER 107299)
  # Silence a warning about a deprecated use of boost bind by boost >= 1.73
  # without dropping support for boost < 1.73
-  ADD_DEFINITIONS(-DBOOST_BIND_GLOBAL_PLACEHOLDERS)
-ENDIF()
+  add_definitions(-DBOOST_BIND_GLOBAL_PLACEHOLDERS)
+endif()

 # Main Library
-SET(${PROJECT_NAME}_HEADERS
-  include/${CUSTOM_HEADER_DIR}/api.hh
-  include/${CUSTOM_HEADER_DIR}/convert-dg-to-py.hh
-  include/${CUSTOM_HEADER_DIR}/dynamic-graph-py.hh
-  include/${CUSTOM_HEADER_DIR}/fwd.hh
-  include/${CUSTOM_HEADER_DIR}/interpreter.hh
-  include/${CUSTOM_HEADER_DIR}/module.hh
-  include/${CUSTOM_HEADER_DIR}/python-compat.hh
-  include/${CUSTOM_HEADER_DIR}/signal.hh
-  include/${CUSTOM_HEADER_DIR}/signal-wrapper.hh
-  )
-
-SET(${PROJECT_NAME}_SOURCES
-  src/interpreter.cc
-  src/dynamic_graph/python-compat.cc
-  src/dynamic_graph/entity-py.cc
-  src/dynamic_graph/convert-dg-to-py.cc
-  )
-
-ADD_LIBRARY(${PROJECT_NAME} SHARED
-  ${${PROJECT_NAME}_SOURCES} ${${PROJECT_NAME}_HEADERS})
-TARGET_INCLUDE_DIRECTORIES(${PROJECT_NAME} SYSTEM PUBLIC ${PYTHON_INCLUDE_DIR})
-TARGET_INCLUDE_DIRECTORIES(${PROJECT_NAME} PUBLIC $<INSTALL_INTERFACE:include>)
-TARGET_LINK_LIBRARIES(${PROJECT_NAME} PUBLIC ${PYTHON_LIBRARY}
-  dynamic-graph::dynamic-graph)
-TARGET_LINK_BOOST_PYTHON(${PROJECT_NAME} PRIVATE)
-
-IF(SUFFIX_SO_VERSION)
-  SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES SOVERSION ${PROJECT_VERSION})
-ENDIF(SUFFIX_SO_VERSION)
-
-TARGET_COMPILE_DEFINITIONS(${PROJECT_NAME} PRIVATE PYTHON_LIBRARY="${PYTHON_LIBRARY}")
-
-INSTALL(TARGETS ${PROJECT_NAME} EXPORT ${TARGETS_EXPORT_NAME} DESTINATION lib)
-
-ADD_SUBDIRECTORY(src)
-IF(BUILD_TESTING)
-  ADD_SUBDIRECTORY(tests)
-ENDIF(BUILD_TESTING)
-
-INSTALL(FILES package.xml DESTINATION share/${PROJECT_NAME})
+set(${PROJECT_NAME}_HEADERS
+    include/${CUSTOM_HEADER_DIR}/api.hh
+    include/${CUSTOM_HEADER_DIR}/convert-dg-to-py.hh
+    include/${CUSTOM_HEADER_DIR}/dynamic-graph-py.hh
+    include/${CUSTOM_HEADER_DIR}/fwd.hh
+    include/${CUSTOM_HEADER_DIR}/interpreter.hh
+    include/${CUSTOM_HEADER_DIR}/module.hh
+    include/${CUSTOM_HEADER_DIR}/python-compat.hh
+    include/${CUSTOM_HEADER_DIR}/signal.hh
+    include/${CUSTOM_HEADER_DIR}/signal-wrapper.hh)
+
+set(${PROJECT_NAME}_SOURCES
+    src/interpreter.cc src/dynamic_graph/python-compat.cc
+    src/dynamic_graph/entity-py.cc src/dynamic_graph/convert-dg-to-py.cc)
+
+add_library(${PROJECT_NAME} SHARED ${${PROJECT_NAME}_SOURCES}
+                                   ${${PROJECT_NAME}_HEADERS})
+target_include_directories(${PROJECT_NAME} PUBLIC $<INSTALL_INTERFACE:include>)
+target_link_libraries(${PROJECT_NAME} PUBLIC dynamic-graph::dynamic-graph)
+modernize_target_link_libraries(
+  ${PROJECT_NAME}
+  SCOPE
+  PUBLIC
+  TARGETS
+  Python${PYTHON_VERSION_MAJOR}::Python
+  LIBRARIES
+  ${PYTHON_LIBRARIES}
+  INCLUDE_DIRS
+  ${PYTHON_INCLUDE_DIRS})
+target_link_boost_python(${PROJECT_NAME} PUBLIC)
+
+if(SUFFIX_SO_VERSION)
+  set_target_properties(${PROJECT_NAME} PROPERTIES SOVERSION ${PROJECT_VERSION})
+endif(SUFFIX_SO_VERSION)
+
+target_compile_definitions(${PROJECT_NAME}
+                           PRIVATE PYTHON_LIBRARY="${PYTHON_LIBRARY}")
+
+install(
+  TARGETS ${PROJECT_NAME}
+  EXPORT ${TARGETS_EXPORT_NAME}
+  DESTINATION lib)
+
+add_subdirectory(src)
+if(BUILD_TESTING)
+  add_subdirectory(tests)
+endif(BUILD_TESTING)
+
+install(FILES package.xml DESTINATION share/${PROJECT_NAME})
--- a/README.md
+++ b/README.md
@@ -3,6 +3,8 @@
 [![Building Status](https://travis-ci.org/stack-of-tasks/dynamic-graph-python.svg?branch=master)](https://travis-ci.org/stack-of-tasks/dynamic-graph-python)
 [![Pipeline status](https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/badges/master/pipeline.svg)](https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/commits/master)
 [![Coverage report](https://gitlab.laas.fr/stack-of-tasks/dynamic-graph-python/badges/master/coverage.svg?job=doc-coverage)](http://projects.laas.fr/stack-of-tasks/doc/stack-of-tasks/dynamic-graph-python/master/coverage/)
+[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
+[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/stack-of-tasks/dynamic-graph-python/master.svg)](https://results.pre-commit.ci/latest/github/stack-of-tasks/dynamic-graph-python)

 Python bindings for dynamic-graph.


--- a/cmake @ 08c2c18b
+++ b/cmake @ 08c2c18b
-Subproject commit 332976cc4d5305256c79a479e55ad7ab2ecc42f1
+Subproject commit 08c2c18b9033c2f0a86b885b589f4fa63a163caf
--- a/doc/footer.html
+++ b/doc/footer.html
@@ -8,4 +8,3 @@
 </center>
 </body>
 </head>
-
--- a/doc/header.html
+++ b/doc/header.html
@@ -4,4 +4,3 @@
      <LINK HREF="package.css" REL="stylesheet" TYPE="text/css">
    </HEAD>
    <BODY>
-
--- a/doc/package.css
+++ b/doc/package.css
@@ -45,8 +45,8 @@ a:link {
    color:#0066CC
 }

-a:hover, a:active { 
-	text-decoration: underline; 
+a:hover, a:active {
+	text-decoration: underline;
 	color: #3C9A35;
 }

@@ -57,7 +57,7 @@ a:visited {
 }

 DIV.memitem
-{ 
+{
  spacing: 10px;
  width:100%;
  background:#FFFFFF;
@@ -70,7 +70,7 @@ DIV.memitem
 }

 DIV.memproto
-{ 
+{
  width:100%;
  background:#F0F0F0;
  font-size:100%;
@@ -82,7 +82,7 @@ DIV.memproto
 }

 DIV.memdoc
-{ 
+{
  padding: 10px;
  width:100%;
  font-size:100%;
@@ -189,7 +189,7 @@ DIV.nav
 }

 DIV.groupHeader
-{ 
+{
  padding-top: 30px;
  padding-bottom: 20px;
  background       : none;
@@ -201,23 +201,23 @@ DIV.groupHeader
  color:#0066CC;
 }

-.directory p 
-{ 
-    margin: 0px; 
-    white-space: nowrap; 
+.directory p
+{
+    margin: 0px;
+    white-space: nowrap;
    font-family: 'Lucida Grande','Lucida Sans Unicode',Verdana,Sans-Serif;
    font-size: 10pt;
    font-weight: normal;
 }


-.directory h3 
-{ 
+.directory h3
+{
    font-family: 'Lucida Grande','Lucida Sans Unicode',Verdana,Sans-Serif;
-    margin: 0px; 
-    margin-top: 1em; 
+    margin: 0px;
+    margin-top: 1em;
    padding-bottom: 20px;
-    font-size: 12pt; 
+    font-size: 12pt;
    font-variant: small-caps;
    text-align: center;
 }
@@ -227,4 +227,3 @@ DIV.groupHeader
    text-decoration: none;
    color:#0066CC
 }
-
--- a/doc/package.dox.cmake
+++ b/doc/package.dox.cmake
@@ -23,8 +23,8 @@ ABBREVIATE_BRIEF       = "The $name class" \
 ALWAYS_DETAILED_SEC    = YES
 INLINE_INHERITED_MEMB  = NO
 FULL_PATH_NAMES        = NO
-STRIP_FROM_PATH        = 
-STRIP_FROM_INC_PATH    = 
+STRIP_FROM_PATH        =
+STRIP_FROM_INC_PATH    =
 SHORT_NAMES            = NO
 JAVADOC_AUTOBRIEF      = YES
 MULTILINE_CPP_IS_BRIEF = NO
@@ -50,7 +50,7 @@ SORT_MEMBER_DOCS       = YES
 SORT_BRIEF_DOCS        = NO
 SORT_BY_SCOPE_NAME     = NO
 MAX_INITIALIZER_LINES  = 30
-FILE_VERSION_FILTER    = 
+FILE_VERSION_FILTER    =
 #---------------------------------------------------------------------------
 # configuration options related to warning and progress messages
 #---------------------------------------------------------------------------
@@ -60,18 +60,18 @@ WARN_IF_UNDOCUMENTED   = YES
 WARN_IF_DOC_ERROR      = YES
 WARN_NO_PARAMDOC       = NO
 WARN_FORMAT            = "$file:$line: $text"
-WARN_LOGFILE           = 
+WARN_LOGFILE           =
 #---------------------------------------------------------------------------
 # configuration options related to the input files
 #---------------------------------------------------------------------------
 RECURSIVE              = YES
-EXCLUDE                = 
+EXCLUDE                =
 EXCLUDE_SYMLINKS       = NO
-EXAMPLE_PATH           = 
+EXAMPLE_PATH           =
 EXAMPLE_PATTERNS       = *
 EXAMPLE_RECURSIVE      = NO
-INPUT_FILTER           = 
-FILTER_PATTERNS        = 
+INPUT_FILTER           =
+FILTER_PATTERNS        =
 FILTER_SOURCE_FILES    = NO
 #---------------------------------------------------------------------------
 # configuration options related to source browsing
@@ -81,7 +81,7 @@ FILTER_SOURCE_FILES    = NO
 #---------------------------------------------------------------------------
 ALPHABETICAL_INDEX     = NO
 COLS_IN_ALPHA_INDEX    = 5
-IGNORE_PREFIX          = 
+IGNORE_PREFIX          =
 #---------------------------------------------------------------------------
 # configuration options related to the HTML output
 #---------------------------------------------------------------------------
@@ -89,8 +89,8 @@ GENERATE_HTML          = YES
 HTML_FILE_EXTENSION    = .html
 HTML_ALIGN_MEMBERS     = YES
 GENERATE_HTMLHELP      = NO
-CHM_FILE               = 
-HHC_LOCATION           = 
+CHM_FILE               =
+HHC_LOCATION           =
 GENERATE_CHI           = NO
 BINARY_TOC             = NO
 TOC_EXPAND             = YES
@@ -106,8 +106,8 @@ LATEX_CMD_NAME         = latex
 MAKEINDEX_CMD_NAME     = makeindex
 COMPACT_LATEX          = NO
 PAPER_TYPE             = a4wide
-EXTRA_PACKAGES         = 
-LATEX_HEADER           = 
+EXTRA_PACKAGES         =
+LATEX_HEADER           =
 PDF_HYPERLINKS         = NO
 USE_PDFLATEX           = NO
 LATEX_BATCHMODE        = NO
@@ -118,8 +118,8 @@ LATEX_HIDE_INDICES     = NO
 RTF_OUTPUT             = rtf
 COMPACT_RTF            = NO
 RTF_HYPERLINKS         = NO
-RTF_STYLESHEET_FILE    = 
-RTF_EXTENSIONS_FILE    = 
+RTF_STYLESHEET_FILE    =
+RTF_EXTENSIONS_FILE    =
 #---------------------------------------------------------------------------
 # configuration options related to the man page output
 #---------------------------------------------------------------------------
@@ -130,8 +130,8 @@ MAN_LINKS              = NO
 # configuration options related to the XML output
 #---------------------------------------------------------------------------
 XML_OUTPUT             = xml
-XML_SCHEMA             = 
-XML_DTD                = 
+XML_SCHEMA             =
+XML_DTD                =
 XML_PROGRAMLISTING     = YES
 #---------------------------------------------------------------------------
 # configuration options for the AutoGen Definitions output
@@ -142,20 +142,20 @@ GENERATE_AUTOGEN_DEF   = NO
 #---------------------------------------------------------------------------
 PERLMOD_LATEX          = NO
 PERLMOD_PRETTY         = YES
-PERLMOD_MAKEVAR_PREFIX = 
+PERLMOD_MAKEVAR_PREFIX =
 #---------------------------------------------------------------------------
-# Configuration options related to the preprocessor   
+# Configuration options related to the preprocessor
 #---------------------------------------------------------------------------
 ENABLE_PREPROCESSING   = YES
 MACRO_EXPANSION        = YES
 EXPAND_ONLY_PREDEF     = YES
 SEARCH_INCLUDES        = YES
-INCLUDE_PATH           = 
-INCLUDE_FILE_PATTERNS  = 
-EXPAND_AS_DEFINED      = 
+INCLUDE_PATH           =
+INCLUDE_FILE_PATTERNS  =
+EXPAND_AS_DEFINED      =
 SKIP_FUNCTION_MACROS   = YES
 #---------------------------------------------------------------------------
-# Configuration::additions related to external references   
+# Configuration::additions related to external references
 #---------------------------------------------------------------------------
 TAGFILES               = \
 	${DYNAMIC_GRAPH_DOCDIR}/html/dynamic-graph.doxytag=${DYNAMIC_GRAPH_DOCDIR}/html
@@ -164,10 +164,10 @@ ALLEXTERNALS           = NO
 EXTERNAL_GROUPS        = YES
 PERL_PATH              = /usr/bin/perl
 #---------------------------------------------------------------------------
-# Configuration options related to the dot tool   
+# Configuration options related to the dot tool
 #---------------------------------------------------------------------------
 #---------------------------------------------------------------------------
-# Configuration::additions related to the search engine   
+# Configuration::additions related to the search engine
 #---------------------------------------------------------------------------
 SEARCHENGINE           = NO

@@ -196,7 +196,7 @@ GENERATE_TODOLIST      = YES
 GENERATE_TESTLIST      = NO
 GENERATE_BUGLIST       = NO
 GENERATE_DEPRECATEDLIST= YES
-ENABLED_SECTIONS       = 
+ENABLED_SECTIONS       =
 SHOW_USED_FILES        = NO
 SHOW_DIRECTORIES       = NO
 #---------------------------------------------------------------------------
@@ -206,7 +206,7 @@ SHOW_DIRECTORIES       = NO
 # configuration options related to the input files
 #---------------------------------------------------------------------------
 FILE_PATTERNS          = *.hh *.idl
-EXCLUDE_PATTERNS       = 
+EXCLUDE_PATTERNS       =
 INPUT                  = ${${PROJECT_NAME}_SOURCE_DIR}/include \
                         ${CMAKE_CURRENT_SOURCE_DIR}/additionalDoc

@@ -260,13 +260,13 @@ GENERATE_AUTOGEN_DEF   = NO
 #---------------------------------------------------------------------------
 GENERATE_PERLMOD       = NO
 #---------------------------------------------------------------------------
-# Configuration options related to the preprocessor   
+# Configuration options related to the preprocessor
 #---------------------------------------------------------------------------
 #---------------------------------------------------------------------------
-# Configuration::additions related to external references   
+# Configuration::additions related to external references
 #---------------------------------------------------------------------------
 #---------------------------------------------------------------------------
-# Configuration options related to the dot tool   
+# Configuration options related to the dot tool
 #---------------------------------------------------------------------------
 CLASS_DIAGRAMS         = YES
 HIDE_UNDOC_RELATIONS   = YES
@@ -282,8 +282,8 @@ CALL_GRAPH             = NO
 GRAPHICAL_HIERARCHY    = YES
 DIRECTORY_GRAPH        = YES
 DOT_IMAGE_FORMAT       = png
-DOT_PATH               = 
-DOTFILE_DIRS           = 
+DOT_PATH               =
+DOTFILE_DIRS           =
 MAX_DOT_GRAPH_DEPTH    = 1000
 DOT_TRANSPARENT        = NO
 DOT_MULTI_TARGETS      = YES

--- a/include/dynamic-graph/python/convert-dg-to-py.hh
+++ b/include/dynamic-graph/python/convert-dg-to-py.hh
@@ -9,7 +9,8 @@ namespace dynamicgraph {
 namespace python {
 namespace convert {

-command::Value toValue(boost::python::object o, const command::Value::Type& type);
+command::Value toValue(boost::python::object o,
+                       const command::Value::Type& type);
 boost::python::object fromValue(const command::Value& value);

 }  // namespace convert

--- a/include/dynamic-graph/python/dynamic-graph-py.hh
+++ b/include/dynamic-graph/python/dynamic-graph-py.hh
@@ -32,14 +32,16 @@ inline bp::tuple to_py_tuple(Iterator begin, Iterator end) {

 template <typename T>
 inline std::vector<T> to_std_vector(const bp::object& iterable) {
-  return std::vector<T>(bp::stl_input_iterator<T>(iterable), bp::stl_input_iterator<T>());
+  return std::vector<T>(bp::stl_input_iterator<T>(iterable),
+                        bp::stl_input_iterator<T>());
 }

 void exposeSignals();

 // Declare functions defined in other source files
 namespace signalBase {
-SignalBase<int>* createSignalWrapper(const char* name, const char* type, bp::object object);
+SignalBase<int>* createSignalWrapper(const char* name, const char* type,
+                                     bp::object object);
 }  // namespace signalBase
 namespace entity {


--- a/include/dynamic-graph/python/interpreter.hh
+++ b/include/dynamic-graph/python/interpreter.hh
@@ -25,11 +25,13 @@ class DYNAMIC_GRAPH_PYTHON_DLLAPI Interpreter {
  /// \brief Method to start python interperter.
  /// \param command string to execute
  /// Method deprecated, you *SHOULD* handle error messages.
-  [[deprecated("you *SHOULD* handle error messages")]] std::string python(const std::string& command);
+  [[deprecated("you *SHOULD* handle error messages")]] std::string python(
+      const std::string& command);

  /// \brief Method to start python interperter.
  /// \param command string to execute, result, stdout, stderr strings
-  void python(const std::string& command, std::string& result, std::string& out, std::string& err);
+  void python(const std::string& command, std::string& result, std::string& out,
+              std::string& err);

  /// \brief Method to exectue a python script.
  /// \param filename the filename

--- a/include/dynamic-graph/python/module.hh
+++ b/include/dynamic-graph/python/module.hh
@@ -43,14 +43,17 @@ bp::object makeEntity2() {
 ///         If some commands or signals are added or removed dynamiccally, then
 ///         it is better to disable the default behaviour and handle it
 ///         specifically.
-template <typename T, typename bases = boost::python::bases<dynamicgraph::Entity>,
+template <typename T,
+          typename bases = boost::python::bases<dynamicgraph::Entity>,
          int Options = AddCommands | AddSignals>
 inline auto exposeEntity() {
  // std::string hiddenClassName ("_" + T::CLASS_NAME);
  std::string hiddenClassName(T::CLASS_NAME);
  namespace bp = boost::python;
-  bp::class_<T, bases, boost::noncopyable> obj(hiddenClassName.c_str(), bp::init<std::string>());
-  /* TODO at the moment, I couldn't easily find a way to define a Python constructor
+  bp::class_<T, bases, boost::noncopyable> obj(hiddenClassName.c_str(),
+                                               bp::init<std::string>());
+  /* TODO at the moment, I couldn't easily find a way to define a Python
+  constructor
   * that would create the entity via the factory and then populate the
   * python object with its commands.
   * This is achieved with a factory function of the same name.
@@ -64,7 +67,8 @@ inline auto exposeEntity() {
            std::cout << "foo" << std::endl;
          assert(dynamic_cast<T*>(ent) != NULL);
          self = bp::object(bp::ptr(static_cast<T*>(ent)));
-          //dynamicgraph::Entity& unused = bp::extract<dynamicgraph::Entity&>(self);
+          //dynamicgraph::Entity& unused =
+  bp::extract<dynamicgraph::Entity&>(self);
          //entity::addCommands(self);
        })
  ;

--- a/include/dynamic-graph/python/signal-wrapper.hh
+++ b/include/dynamic-graph/python/signal-wrapper.hh
@@ -35,7 +35,8 @@ class SignalWrapper : public Signal<T, Time> {

  static bool checkCallable(pyobject c, std::string& error);

-  SignalWrapper(std::string name, pyobject callable) : parent_t(name), callable(callable) {
+  SignalWrapper(std::string name, pyobject callable)
+      : parent_t(name), callable(callable) {
    typedef boost::function2<T&, T&, Time> function_t;
    function_t f = boost::bind(&SignalWrapper::call, this, _1, _2);
    this->setFunction(f);

--- a/include/dynamic-graph/python/signal.hh
+++ b/include/dynamic-graph/python/signal.hh
@@ -18,11 +18,15 @@ auto exposeSignal(const std::string& name) {
  namespace bp = boost::python;

  typedef Signal<T, Time> S_t;
-  bp::class_<S_t, bp::bases<SignalBase<Time> >, boost::noncopyable> obj(name.c_str(), bp::init<std::string>());
-  obj.add_property("value", bp::make_function(&S_t::accessCopy, bp::return_value_policy<bp::copy_const_reference>()),
-                   &S_t::setConstant,  // TODO check the setter
-                   "the signal value.\n"
-                   "warning: for Eigen objects, sig.value[0] = 1. may not work).");
+  bp::class_<S_t, bp::bases<SignalBase<Time> >, boost::noncopyable> obj(
+      name.c_str(), bp::init<std::string>());
+  obj.add_property(
+      "value",
+      bp::make_function(&S_t::accessCopy,
+                        bp::return_value_policy<bp::copy_const_reference>()),
+      &S_t::setConstant,  // TODO check the setter
+      "the signal value.\n"
+      "warning: for Eigen objects, sig.value[0] = 1. may not work).");
  return obj;
 }

@@ -31,7 +35,8 @@ auto exposeSignalWrapper(const std::string& name) {
  namespace bp = boost::python;

  typedef SignalWrapper<T, Time> S_t;
-  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(name.c_str(), bp::no_init);
+  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(
+      name.c_str(), bp::no_init);
  return obj;
 }

@@ -40,7 +45,8 @@ auto exposeSignalPtr(const std::string& name) {
  namespace bp = boost::python;

  typedef SignalPtr<T, Time> S_t;
-  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(name.c_str(), bp::no_init);
+  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(
+      name.c_str(), bp::no_init);
  return obj;
 }

@@ -49,7 +55,8 @@ auto exposeSignalTimeDependent(const std::string& name) {
  namespace bp = boost::python;

  typedef SignalTimeDependent<T, Time> S_t;
-  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(name.c_str(), bp::no_init);
+  bp::class_<S_t, bp::bases<Signal<T, Time> >, boost::noncopyable> obj(
+      name.c_str(), bp::no_init);
  return obj;
 }


--- a/package.xml
+++ b/package.xml
 <?xml version="1.0"?>
 <package format="3">
  <name>dynamic-graph-python</name>
-  <version>4.0.4</version>
-  <description>
-    Dynamic graph library Python bindings
-  </description>
+  <version>4.0.11</version>
+  <description>Dynamic graph library Python bindings</description>
  <maintainer email="guilhem.saurel@laas.fr">Guilhem Saurel</maintainer>
-  <license>BSD</license>
-
-  <url>http://github.com/stack-of-tasks/dynamic-graph-python</url>
  <author>Nicolas Mansard</author>
  <author>Olivier Stasse</author>
+  <license>BSD</license>
+
+  <url type="website">https://github.com/stack-of-tasks/dynamic-graph-python</url>

  <build_depend>git</build_depend>
  <build_depend>doxygen</build_depend>
-  <doc_depend>doxygen</doc_depend>
-  <!-- The following tags are recommended by REP-136 -->
+
+  <!-- The following tag is recommended by REP-136 -->
  <exec_depend condition="$ROS_VERSION == 1">catkin</exec_depend>
-  <exec_depend condition="$ROS_VERSION == 2">ament_cmake</exec_depend>
-  <depend>dynamic-graph</depend>
+
+  <depend condition="$ROS_PYTHON_VERSION == 2">python</depend>
+  <depend condition="$ROS_PYTHON_VERSION == 3">python3</depend>
+  <depend condition="$ROS_PYTHON_VERSION == 2">python-numpy</depend>
+  <depend condition="$ROS_PYTHON_VERSION == 3">python3-numpy</depend>
+  <depend>eigen</depend>
  <depend>boost</depend>
  <depend>eigenpy</depend>
+  <depend>dynamic-graph</depend>

  <buildtool_depend>cmake</buildtool_depend>
-
  <export>
    <build_type>cmake</build_type>
  </export>
-
 </package>
--- a/pyproject.toml
+++ b/pyproject.toml
+[tool.black]
+exclude = "cmake"
+extend-exclude = "tests/test_python-syntax_error.py"
--- a/setup.cfg
+++ b/setup.cfg
+[flake8]
+exclude = cmake,tests/test_python-syntax_error.py
+max-line-length = 88
+ignore = E226, E704, E24, E121, W504, E126, E123, W503, E203
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
-#  Python bindings
+# Python bindings

-ADD_SUBDIRECTORY(dynamic_graph)
+add_subdirectory(dynamic_graph)

-SET(PYTHON_SOURCES
-  __init__.py
-  attrpath.py
-  entity.py
-  signal_base.py
-  script_shortcuts.py
-  tools.py
-  )
+set(PYTHON_SOURCES __init__.py attrpath.py entity.py signal_base.py
+                   script_shortcuts.py tools.py)

-FOREACH(source ${PYTHON_SOURCES})
-  PYTHON_INSTALL_ON_SITE(dynamic_graph ${source})
-ENDFOREACH(source)
+foreach(source ${PYTHON_SOURCES})
+  python_install_on_site(dynamic_graph ${source})
+endforeach(source)

 # --- ADD the wrap on the dg modules
-LINK_DIRECTORIES(${DYNAMIC_GRAPH_PLUGINDIR})
-DYNAMIC_GRAPH_PYTHON_MODULE("tracer" dynamic-graph::tracer tracer-wrap
-  SOURCE_PYTHON_MODULE ${CMAKE_CURRENT_SOURCE_DIR}/dynamic_graph/tracer/wrap.cc)
-DYNAMIC_GRAPH_PYTHON_MODULE("tracer_real_time" dynamic-graph::tracer-real-time tracer_real_time-wrap
-  SOURCE_PYTHON_MODULE ${CMAKE_CURRENT_SOURCE_DIR}/dynamic_graph/tracer_real_time/wrap.cc)
+link_directories(${DYNAMIC_GRAPH_PLUGINDIR})
+dynamic_graph_python_module(
+  "tracer" dynamic-graph::tracer tracer-wrap SOURCE_PYTHON_MODULE
+  ${CMAKE_CURRENT_SOURCE_DIR}/dynamic_graph/tracer/wrap.cc)
+dynamic_graph_python_module(
+  "tracer_real_time" dynamic-graph::tracer-real-time tracer_real_time-wrap
+  SOURCE_PYTHON_MODULE
+  ${CMAKE_CURRENT_SOURCE_DIR}/dynamic_graph/tracer_real_time/wrap.cc)
--- a/src/dynamic_graph/CMakeLists.txt
+++ b/src/dynamic_graph/CMakeLists.txt
-# Copyright 2010-2021, Florent Lamiraux, Thomas Moulard, Olivier Stasse, Guilhem Saurel, JRL, CNRS/AIST, LAAS-CNRS
+# Copyright 2010-2021, Florent Lamiraux, Thomas Moulard, Olivier Stasse, Guilhem
+# Saurel, JRL, CNRS/AIST, LAAS-CNRS

-SET(PYTHON_MODULE wrap)
+set(PYTHON_MODULE wrap)

-ADD_LIBRARY(${PYTHON_MODULE} MODULE
-  debug-py.cc
-  dynamic-graph-py.cc
-  factory-py.cc
-  pool-py.cc
-  signal-base-py.cc
-  signal-wrapper.cc
-  )
+add_library(
+  ${PYTHON_MODULE} MODULE debug-py.cc dynamic-graph-py.cc factory-py.cc
+                          pool-py.cc signal-base-py.cc signal-wrapper.cc)

-TARGET_LINK_LIBRARIES(${PYTHON_MODULE} PUBLIC ${PROJECT_NAME} eigenpy::eigenpy)
-TARGET_LINK_BOOST_PYTHON(${PYTHON_MODULE} PRIVATE)
+target_link_libraries(${PYTHON_MODULE} PUBLIC ${PROJECT_NAME} eigenpy::eigenpy)

 # Remove prefix lib
-SET_TARGET_PROPERTIES(${PYTHON_MODULE} PROPERTIES PREFIX "")
+set_target_properties(${PYTHON_MODULE} PROPERTIES PREFIX "")

-IF(UNIX AND NOT APPLE)
-  SET_TARGET_PROPERTIES(${PYTHON_MODULE} PROPERTIES INSTALL_RPATH "\$ORIGIN/../../..")
-ENDIF()
+if(UNIX AND NOT APPLE)
+  set_target_properties(${PYTHON_MODULE} PROPERTIES INSTALL_RPATH
+                                                    "\$ORIGIN/../../..")
+endif()

-INSTALL(TARGETS ${PYTHON_MODULE}
+install(
+  TARGETS ${PYTHON_MODULE}
  EXPORT ${TARGETS_EXPORT_NAME}
  DESTINATION ${PYTHON_SITELIB}/dynamic_graph)
No results found