Skip to content
Snippets Groups Projects

[ADD] Update calibration coefficient via serial port

Merged Thomas Walter requested to merge twalter/core:UpdateCoefficient into main
All threads resolved!

Add the functionnality to change the dataAcquisition parameters (gain, offset) via the serial port.

Merge request reports

Approved by

Merged by Clément FoucherClément Foucher 1 year ago (Apr 3, 2023 7:45am UTC)

Merge details

  • Changes merged into main with 0463e9ae (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Clément Foucher
  • Some minor comments. Please respond to all of them, and post a test main.cpp as an attachment.

  • Thomas Walter added 1 commit

    added 1 commit

    • 5aee1f28 - Taken account of PR comments

    Compare with previous version

  • Author Developer

    main.cpp

    To test :

    1. if you only have a SPIN : you can conly test the update of offset (you can type any value of gain, as 0 is measured, modifying gain won't affect the result).

    2. with TWIST, modify gain/offset then enter power mode to see that values are different with same signal

  • Clément Foucher resolved all threads

    resolved all threads

  • Thomas Walter added 1 commit

    added 1 commit

    • 08efc77a - Taken account of PR comments

    Compare with previous version

  • Thomas Walter added 1 commit

    added 1 commit

    • f725403a - Added const to the arguments of get_calibration_coefficients

    Compare with previous version

  • Clément Foucher approved this merge request

    approved this merge request

  • I propose the following solution :

    By default we support CRLF EOL characters which seems to be the default in many serial console programs. A IFDEF statement permits to change to CR or LF EOL.

    IMO it is not necessary to add complexity in order to have all 3 natively supported without a config input, but it is necessary to be able to configure it to the user flavor. However, I still believe that the default value should be CRLF as it seems to become a practical standard.

    A KConfig option can be added to solve this issue and merge quickly.

    Edited by Jean Alinei
  • Thomas Walter added 2 commits

    added 2 commits

    Compare with previous version

  • Thomas Walter added 1 commit

    added 1 commit

    Compare with previous version

  • Clément Foucher resolved all threads

    resolved all threads

  • Clément Foucher added 8 commits

    added 8 commits

    • fcd6654d - 1 commit from branch owntech/power-api:main
    • 1a28f116 - Modified platformio.ini to set EOL character to LF
    • 082c2159 - Added functionnality to change the dataAcquisition parameters (gain, offset) via the serial port
    • 62d3aca7 - Taken account of PR comments
    • f3b3919b - Added const to the arguments of get_calibration_coefficients
    • 1b989dcf - Set back EOL char to CRLF
    • 344b8027 - Adapted code to CRLF EOL char
    • 9c0a1501 - Corrected spaces into tab

    Compare with previous version

  • Please register or sign in to reply
    Loading