[ADD] Update calibration coefficient via serial port
Add the functionnality to change the dataAcquisition parameters (gain, offset) via the serial port.
Merge request reports
Activity
added Acquisition chain label
requested review from @jalinei
assigned to @cfoucher
- Resolved by Clément Foucher
- Resolved by Clément Foucher
- Resolved by Clément Foucher
- Resolved by Clément Foucher
To test :
-
if you only have a SPIN : you can conly test the update of offset (you can type any value of gain, as 0 is measured, modifying gain won't affect the result).
-
with TWIST, modify gain/offset then enter power mode to see that values are different with same signal
-
added 1 commit
- f725403a - Added const to the arguments of get_calibration_coefficients
I propose the following solution :
By default we support CRLF EOL characters which seems to be the default in many serial console programs. A IFDEF statement permits to change to CR or LF EOL.
IMO it is not necessary to add complexity in order to have all 3 natively supported without a config input, but it is necessary to be able to configure it to the user flavor. However, I still believe that the default value should be CRLF as it seems to become a practical standard.
A KConfig option can be added to solve this issue and merge quickly.
Edited by Jean Alineiadded 2 commits
- Resolved by Clément Foucher
- Resolved by Clément Foucher
added 8 commits
-
fcd6654d - 1 commit from branch
owntech/power-api:main
- 1a28f116 - Modified platformio.ini to set EOL character to LF
- 082c2159 - Added functionnality to change the dataAcquisition parameters (gain, offset) via the serial port
- 62d3aca7 - Taken account of PR comments
- f3b3919b - Added const to the arguments of get_calibration_coefficients
- 1b989dcf - Set back EOL char to CRLF
- 344b8027 - Adapted code to CRLF EOL char
- 9c0a1501 - Corrected spaces into tab
Toggle commit list-
fcd6654d - 1 commit from branch