From e044debfc4001c7409920d502fbe084c8f6ce3a2 Mon Sep 17 00:00:00 2001
From: Justin Carpentier <justin.carpentier@inria.fr>
Date: Sat, 10 Feb 2024 18:50:39 +0100
Subject: [PATCH] decompositions: use EigenBaseVisitor for Eigen::{LLT,LDLT}
---
include/eigenpy/decompositions/LDLT.hpp | 3 +++
include/eigenpy/decompositions/LLT.hpp | 3 +++
2 files changed, 6 insertions(+)
diff --git a/include/eigenpy/decompositions/LDLT.hpp b/include/eigenpy/decompositions/LDLT.hpp
index 34740541..2a635a21 100644
--- a/include/eigenpy/decompositions/LDLT.hpp
+++ b/include/eigenpy/decompositions/LDLT.hpp
@@ -10,6 +10,7 @@
#include "eigenpy/eigenpy.hpp"
#include "eigenpy/utils/scalar-name.hpp"
+#include "eigenpy/eigen/EigenBase.hpp"
namespace eigenpy {
@@ -36,6 +37,8 @@ struct LDLTSolverVisitor
bp::args("self", "matrix"),
"Constructs a LDLT factorization from a given matrix."))
+ .def(EigenBaseVisitor<Solver>())
+
.def("isNegative", &Solver::isNegative, bp::arg("self"),
"Returns true if the matrix is negative (semidefinite).")
.def("isPositive", &Solver::isPositive, bp::arg("self"),
diff --git a/include/eigenpy/decompositions/LLT.hpp b/include/eigenpy/decompositions/LLT.hpp
index b0a1e1b5..1996d6cc 100644
--- a/include/eigenpy/decompositions/LLT.hpp
+++ b/include/eigenpy/decompositions/LLT.hpp
@@ -10,6 +10,7 @@
#include "eigenpy/eigenpy.hpp"
#include "eigenpy/utils/scalar-name.hpp"
+#include "eigenpy/eigen/EigenBase.hpp"
namespace eigenpy {
@@ -36,6 +37,8 @@ struct LLTSolverVisitor
bp::args("self", "matrix"),
"Constructs a LLT factorization from a given matrix."))
+ .def(EigenBaseVisitor<Solver>())
+
.def("matrixL", &matrixL, bp::arg("self"),
"Returns the lower triangular matrix L.")
.def("matrixU", &matrixU, bp::arg("self"),
--
GitLab