From 561796776612b236fecd57abcaf88d93d3991e1c Mon Sep 17 00:00:00 2001
From: Justin Carpentier <justin.carpentier@inria.fr>
Date: Mon, 28 Dec 2020 17:36:32 +0100
Subject: [PATCH] geometry: move overload to visitor

---
 include/eigenpy/angle-axis.hpp | 4 ++--
 include/eigenpy/quaternion.hpp | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/eigenpy/angle-axis.hpp b/include/eigenpy/angle-axis.hpp
index ea78f4df..d5ad5aa1 100644
--- a/include/eigenpy/angle-axis.hpp
+++ b/include/eigenpy/angle-axis.hpp
@@ -34,8 +34,6 @@ namespace eigenpy
     }
   };
 
-  BOOST_PYTHON_FUNCTION_OVERLOADS(isApproxAngleAxis_overload,call<Eigen::AngleAxisd>::isApprox,2,3)
-
   template<typename AngleAxis>
   class AngleAxisVisitor
   : public bp::def_visitor< AngleAxisVisitor<AngleAxis> >
@@ -48,6 +46,8 @@ namespace eigenpy
     typedef typename Eigen::Quaternion<Scalar,0> Quaternion;
     typedef Eigen::RotationBase<AngleAxis,3> RotationBase;
     
+    BOOST_PYTHON_FUNCTION_OVERLOADS(isApproxAngleAxis_overload,call<AngleAxis>::isApprox,2,3)
+    
   public:
 
     template<class PyClass>
diff --git a/include/eigenpy/quaternion.hpp b/include/eigenpy/quaternion.hpp
index 6d5f1ffc..05d88a64 100644
--- a/include/eigenpy/quaternion.hpp
+++ b/include/eigenpy/quaternion.hpp
@@ -88,8 +88,6 @@ namespace eigenpy
     }
   };
 
-  BOOST_PYTHON_FUNCTION_OVERLOADS(isApproxQuaternion_overload,call<Eigen::Quaterniond>::isApprox,2,3)
-
   template<typename Quaternion>
   class QuaternionVisitor
   :  public bp::def_visitor< QuaternionVisitor<Quaternion> >
@@ -103,6 +101,8 @@ namespace eigenpy
     typedef typename QuaternionBase::Matrix3 Matrix3;
 
     typedef typename QuaternionBase::AngleAxisType AngleAxis;
+    
+    BOOST_PYTHON_FUNCTION_OVERLOADS(isApproxQuaternion_overload,call<Quaternion>::isApprox,2,3)
 
   public:
 
-- 
GitLab