diff --git a/include/dynamic-graph/signal-ptr.h b/include/dynamic-graph/signal-ptr.h index d66729e74d027620a9b17d86560c1d981cc3c3d5..69296f972bf330dccb35a9ec8d195f75875235fe 100644 --- a/include/dynamic-graph/signal-ptr.h +++ b/include/dynamic-graph/signal-ptr.h @@ -62,11 +62,7 @@ namespace dynamicgraph const SignalBase<Time>* getAbstractPtr () const; // throw virtual void plug( SignalBase<Time>* ref ); - //Useless function, didn't find any use of this one - /*virtual void unplug () { plug(NULL); } - virtual bool isPluged () const DYNAMIC_GRAPH_DEPRECATED { - return isPlugged (); - }*/ + virtual void unplug () { plug(NULL); } virtual bool isPlugged () const { return (NULL!=signalPtr); } virtual SignalBase<Time>* getPluged () const { return signalPtr; } diff --git a/src/debug/logger.cpp b/src/debug/logger.cpp index 6ebcaafd46687c37768038ad33bfe6c86edca22e..b4c2fc3bad2ff3ea4d6db0e255b9e142fcabd61c 100644 --- a/src/debug/logger.cpp +++ b/src/debug/logger.cpp @@ -61,13 +61,11 @@ namespace dynamicgraph (m_lv==VERBOSITY_INFO_WARNING_ERROR && isDebugMsg(type))) return; - //TODO Modif ici // if print is allowed by current verbosity level if( isStreamMsg(type)) { - int l = line; // check whether counter already exists - string id = file+/*toString(line)*/+ l; + string id = file+toString(line); map<string,double>::iterator it = m_stream_msg_counters.find(id); if(it == m_stream_msg_counters.end()) { diff --git a/tests/factory.cpp b/tests/factory.cpp index 266bf5459d16974dc67703c21bd48d5ee3e34f2e..45a23722aa299387459d04bd254f1b6707e7f643 100644 --- a/tests/factory.cpp +++ b/tests/factory.cpp @@ -1,7 +1,6 @@ // Copyright 2010 Thomas Moulard. // -#include <iostream> #include <sstream> #include <dynamic-graph/factory.h> #include <dynamic-graph/entity.h> diff --git a/tests/signal-cast-registerer.cpp b/tests/signal-cast-registerer.cpp index b47843c329428e4380758466f2817119f3b3e606..006f0e6080a01f274b35804f8c9879c598b76da1 100644 --- a/tests/signal-cast-registerer.cpp +++ b/tests/signal-cast-registerer.cpp @@ -88,31 +88,13 @@ struct EigenCastRegisterer_M : public dynamicgraph::SignalCastRegisterer static void dispMatrix (const boost::any& object, std::ostream& os) { const bnuMatrix& m = boost::any_cast<bnuMatrix> (object); - os << "[ "; - for (int i = 0; i < m.rows(); ++i){ - os << "[ "; - for (int j = 0; j < m.cols(); ++j) { - os << m(i, j) << " "; - } - if (i != m.rows()-1){ - os << "]; "; - } - else{ - os << "] "; - } - } - os << " ];" << std::endl; + os << m << std::endl; } static void traceMatrix (const boost::any& object, std::ostream& os) { const bnuMatrix& m = boost::any_cast<bnuMatrix> (object); - for (int i = 0; i < m.rows(); ++i){ - for (int j = 0; j < m.cols(); ++j){ - os << m(i,j) << " "; - } - } - os << std::endl; + os << m << std::endl; } }; @@ -371,22 +353,3 @@ BOOST_AUTO_TEST_CASE (custom_matrix_registerer) { //[...]((...)) } - -// One issue with the strategy used by the -// dynamicgraph::SignalCastRegisterer is that it relies on the -// typeid. In practice, it means that two signals defined in two -// different libraries will have different typeid and one will not be -// able to plug one into the other unless the symbol have merged when -// the plug-in is loaded. See man(3) dlopen in Linux for more -// information about plug-in loading and the RTLD_GLOBAL flag -// necessary to make cast registerer work as expected. -// -// Here we make sure that two instances of the same type -// declared in two separate libraries are resolved into the -// same typeid. -/*BOOST_AUTO_TEST_CASE (typeid_issue) -{ - BOOST_CHECK (typeid(vA) == typeid(vB)); - BOOST_CHECK_EQUAL (std::string (typeid(vA).name ()), - std::string (typeid(vB).name ())); -}*/ \ No newline at end of file