Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Guilhem Saurel
ndcurves
Commits
ce872cf6
Commit
ce872cf6
authored
Feb 11, 2020
by
Wolfgang Merkt
Browse files
Address review comments
parent
e977fc88
Changes
1
Hide whitespace changes
Inline
Side-by-side
include/curves/optimization/details.h
View file @
ce872cf6
...
...
@@ -174,7 +174,7 @@ problem_data<Point, Numeric, Safe> setup_control_points(const problem_definition
// add remaining variables (only if no end_pos constraints)
for
(;
i
<
numControlPoints
;
++
i
)
variables_
.
push_back
(
var_t
::
Zero
(
pDef
.
dim_
));
if
(
numControlPoints
<
numConstants
)
{
if
(
numControlPoints
<
=
numConstants
)
{
throw
std
::
runtime_error
(
"numControlPoints < numConstants"
);
}
if
(
numControlPoints
!=
variables_
.
size
())
{
...
...
@@ -281,7 +281,7 @@ quadratic_variable<Numeric> bezier_product(In PointsBegin1, In PointsEnd1, In Po
typedef
Eigen
::
Matrix
<
Numeric
,
Eigen
::
Dynamic
,
1
>
vector_x_t
;
unsigned
int
nPoints1
=
(
unsigned
int
)(
std
::
distance
(
PointsBegin1
,
PointsEnd1
)),
nPoints2
=
(
unsigned
int
)(
std
::
distance
(
PointsBegin2
,
PointsEnd2
));
if
(
nPoints1
<
0
||
nPoints2
<
0
)
{
if
(
nPoints1
<
=
0
||
nPoints2
<
=
0
)
{
throw
std
::
runtime_error
(
"This should never happen because an unsigned int cannot go negative without underflowing."
);
}
unsigned
int
deg1
=
nPoints1
-
1
,
deg2
=
nPoints2
-
1
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment