From f1bad2ea01b22e07dd96f37a473c16ff27fddd5d Mon Sep 17 00:00:00 2001
From: Julian Viereck <jviereck@tuebingen.mpg.de>
Date: Tue, 15 Jun 2021 19:58:46 -0400
Subject: [PATCH] Address review comments
---
python/example_robot_data/robots_loader.py | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/python/example_robot_data/robots_loader.py b/python/example_robot_data/robots_loader.py
index f57238f..8eb0d6e 100644
--- a/python/example_robot_data/robots_loader.py
+++ b/python/example_robot_data/robots_loader.py
@@ -266,13 +266,19 @@ class Solo8Loader(RobotLoader):
free_flyer = True
+class SoloLoader(Solo8Loader):
+ def __init__(self, *args, **kwargs):
+ warnings.warn('"solo" is deprecated, please try to load "solo8"')
+ return super(SoloLoader, self).__init__(*args, **kwargs)
+
+
class Solo12Loader(Solo8Loader):
urdf_filename = "solo12.urdf"
-def loadSolo(solo8=True):
+def loadSolo(solo=True):
warnings.warn(_depr_msg('loadSolo()', 'solo8'), FutureWarning, 2)
- loader = Solo8Loader if solo8 else Solo12Loader
+ loader = Solo8Loader if solo else Solo12Loader
return loader().robot
@@ -499,6 +505,7 @@ ROBOTS = {
'simple_humanoid': SimpleHumanoidLoader,
'simple_humanoid_classical': SimpleHumanoidClassicalLoader,
'solo': SoloLoader,
+ 'solo8': Solo8Loader,
'solo12': Solo12Loader,
'finger_edu': FingerEduLoader,
'talos': TalosLoader,
--
GitLab